Mike Percy has posted comments on this change. Change subject: docs: KUDU-1767. Document possible client op reordering ......................................................................
Patch Set 4: (10 comments) http://gerrit.cloudera.org:8080/#/c/5464/4//COMMIT_MSG Commit Message: PS4, Line 7: docs: KUDU-1767. Document possible client op reordering > nit: it seems KUDU-1767 is not exactly about documenting write operations r Well, we are documenting KUDU-1767. Are you saying it's confusing? http://gerrit.cloudera.org:8080/#/c/5464/3/docs/transaction_semantics.adoc File docs/transaction_semantics.adoc: PS3, Line 217: In `AUTO_ > nit: noticeable Done http://gerrit.cloudera.org:8080/#/c/5464/4/docs/transaction_semantics.adoc File docs/transaction_semantics.adoc: PS4, Line 220: noticable > nit: noticeable Done http://gerrit.cloudera.org:8080/#/c/5464/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: PS4, Line 53: read > guess we should remove this too Done http://gerrit.cloudera.org:8080/#/c/5464/4/java/kudu-client/src/main/java/org/apache/kudu/client/SessionConfiguration.java File java/kudu-client/src/main/java/org/apache/kudu/client/SessionConfiguration.java: PS4, Line 57: flush : * simultaneously > nit: may be, stop defining flush via flush and replace with thanks for the good suggestion, done PS4, Line 165: FlushMode#AUTO_FLUSH_BACKGROUND > IIRC this is also true for MANUAL_FLUSH mode as well. Done http://gerrit.cloudera.org:8080/#/c/5464/4/src/kudu/client/client.h File src/kudu/client/client.h: PS4, Line 1227: to Kudu > nit: consider dropping that Done PS4, Line 1227: This : /// is because the buffers may flush concurrently > nit: consider describing what it means in terms of write operations, may be Done PS4, Line 1242: to Kudu > nit: consider dropping Done PS4, Line 1243: This is because the buffers may : /// flush concurrently > nit: ditto with explaining that in terms of write operations sent to the se Done -- To view, visit http://gerrit.cloudera.org:8080/5464 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65215d833c65e54fcf080d61adc5f6ed3d303224 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
