Adar Dembo has posted comments on this change. Change subject: tablet: make time-based flushing configurable ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5690/1/src/kudu/tablet/tablet_peer_mm_ops.cc File src/kudu/tablet/tablet_peer_mm_ops.cc: Line 38: DEFINE_int32(flush_mrs_time_threshold_secs, 2 * 60, Would be nice if the name was more consistent with flush_threshold_mb. So maybe make this flush_threshold_secs? Or maybe make the other one flush_mrs_threshold_mb and this one flush_mrs_threshold_secs? -- To view, visit http://gerrit.cloudera.org:8080/5690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9a546b82e5b5db76473455df1eab2769c443c87 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
