Alexey Serbin has posted comments on this change. Change subject: [TLS cert management] TLS cert generation unit tests ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5672/1/src/kudu/security/test/cert_management-test.cc File src/kudu/security/test/cert_management-test.cc: PS1, Line 382: static const struct TestKeyInfo { : const string fpath; : const char* data; : } kKeyInfo[] = { : { : ca_private_key_file_, : kCaPrivateKey_, : }, : { : ca_exp_private_key_file_, : kCaExpPrivateKey_, : }, : }; > I think having proper named field is more readable than first, second. But I decided to simplify things and remove the loop at all. -- To view, visit http://gerrit.cloudera.org:8080/5672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I281a7b1135c3f64d300a1cc31f304fa2609d54fd Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
