Henry Robinson has posted comments on this change. Change subject: Don't build kudu_test_* if NO_TESTS set ......................................................................
Patch Set 2: My reason is that adding set(NO_TESTS 1) in an Impala CMakefile.txts looks weird if it doesn't actually disable tests. (We don't want to build tests because... they get run by Kudu anyhow :)). >From Kudu's perspective you already have ADD_KUDU_TEST, so it seems consistent >to say NO_KUDU_TESTS. I don't feel strongly though - didn't realise there were many dependencies on that variable. Want me to change it back? -- To view, visit http://gerrit.cloudera.org:8080/5711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69344fc79cdda30456ab261838c5bc50bab1a420 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
