Dan Burkert has posted comments on this change. Change subject: KUDU-1673 [java client] more informative kudu-spark write error ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/5725/6//COMMIT_MSG Commit Message: PS6, Line 10: It would be better to throw : an exception which contained all of the errors encountered. I may be misunderstanding - but I don't see the motivation for this change. Will WriteException's toString or message contain a sample of the row errors? Why is it better to throw an exception which contains all of the errors? Callers will have to downcast or catch the specific error manually and then to-string those, I don't see that being a likely pattern in user applications. http://gerrit.cloudera.org:8080/#/c/5725/6/java/kudu-client/src/main/java/org/apache/kudu/client/WriteException.java File java/kudu-client/src/main/java/org/apache/kudu/client/WriteException.java: Line 23: public class WriteException extends RuntimeException { Add visibility/stability annotations. Line 28: * Default constructor. All of the block comments in this file are in the scala style, not the java style. PS6, Line 36: A no capital here and below -- To view, visit http://gerrit.cloudera.org:8080/5725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I663dddbf1b01f9c3d90f92dd484fc1a0018243c5 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: eric-maynard <[email protected]> Gerrit-Reviewer: Chris George <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: eric-maynard <[email protected]> Gerrit-HasComments: Yes
