Dan Burkert has posted comments on this change. Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5439/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java: Line 568: case IS_NULL: return none(column); > does our 'in-list' API permit 'in (NULL, 1, 3) type queries? we should be c It does not, since it would make it more complicated, and adding a NULL value to an IN list has no effect, since NULL is not equal to NULL. For example: postgres=# create table t (a bigint primary key, b bigint); CREATE TABLE postgres=# insert into t values (0, 0), (1, null); INSERT 0 2 postgres=# select * from t where b in (99, null); a | b ---+--- (0 rows) -- To view, visit http://gerrit.cloudera.org:8080/5439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide23ab6d3cad524553aa6ea5c44570fdadde5ace Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
