Alexey Serbin has posted comments on this change. Change subject: [TLS cert management] added protobuf interface ......................................................................
Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/5673/1/src/kudu/security/security.proto File src/kudu/security/security.proto: Line 52: DER = 0; > should have an UNKNOWN = 999 first Done PS1, Line 63: X509CertSigningRequestPB > I think to clarify that this isn't a normal 'RequestPB' (i.e. an RPC reques Done Line 112: optional Error error = 1; > If you're using the 'extend ErrorStatusPB' thing above, you don't need to i woops, I was confused with the nested extension syntax. Line 134: enum Code { > instead of separate codes for each method, might be better to just have a P Good idea. Line 171: optional Error error = 1; > see above Done PS1, Line 174: correspoding > typo Done PS1, Line 184: authentity > typo Done PS1, Line 187: Get prior, current and next root CA certificates. At every moment, : // only one pair of (private key, CA cert) is active: > see above Done -- To view, visit http://gerrit.cloudera.org:8080/5673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ff31e56be42bfa8d0f9b908ba2ccd2734407f55 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
