Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [5/n]: Rename sasl_[client|server] to [client|server]_negotiation ......................................................................
Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/5759/1/src/kudu/rpc/client_negotiation.cc File src/kudu/rpc/client_negotiation.cc: Line 151: // TODO(unknown): Support security flags. > warning: missing username/bug in TODO [google-readability-todo] Done Line 190: } > warning: don't use else after return [readability-else-after-return] Done Line 466: switch (id) { > warning: missing username/bug in TODO [google-readability-todo] Done Line 508: (*psecret)->len = len; > warning: either cast from 'int' to 'size_t' (aka 'unsigned long') is ineffe Done http://gerrit.cloudera.org:8080/#/c/5759/2/src/kudu/rpc/client_negotiation.cc File src/kudu/rpc/client_negotiation.cc: Line 509: memcpy((*psecret)->data, plain_pass_.c_str(), len + 1); > warning: either cast from 'int' to 'size_t' (aka 'unsigned long') is ineffe Done http://gerrit.cloudera.org:8080/#/c/5759/2/src/kudu/rpc/client_negotiation.h File src/kudu/rpc/client_negotiation.h: Line 32: #include "kudu/util/net/socket.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/5759/1/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: Line 118: // TODO(unknown): Support security flags. > warning: missing username/bug in TODO [google-readability-todo] Done Line 162: } > warning: don't use else after return [readability-else-after-return] Done http://gerrit.cloudera.org:8080/#/c/5759/1/src/kudu/rpc/server_negotiation.h File src/kudu/rpc/server_negotiation.h: Line 30: #include "kudu/util/monotime.h" > warning: #includes are not sorted properly [llvm-include-order] Done -- To view, visit http://gerrit.cloudera.org:8080/5759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4fb4bcdb7c7a43eea88b2911d2b2e75eafa62b0 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
