Alexey Serbin has posted comments on this change. Change subject: [security] groundwork for cert signing service ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5671/1/src/kudu/security/crypto/cert_management.h File src/kudu/security/crypto/cert_management.h: PS1, Line 174: // The configuration and hostnames/ips are made separate parameters to : // work around limitations of old gcc 4.4.x compiler. Ideally, both hostnames : // and ips should have been fields of the Config structure. > hrm, you removed the comment, but now it doesn't really make sense why it's OK, here is the issue: non-devetoolset gcc compiler used by Jenkins slaves does not support non-trivial designated initializers: 20:22:58 /home/jenkins-slave/workspace/kudu-0/src/kudu/security/test/cert_management-test.cc:94:5: sorry, unimplemented: non-trivial designated initializers not supported Yes, that's C99 feature and C++11 standard does not have this mentioned, and it isn't valid C++11 syntax. I'll update this. -- To view, visit http://gerrit.cloudera.org:8080/5671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2ce55d38f4d06172fadaaa702f4550997d9bc8f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
