Dan Burkert has submitted this change and it was merged. Change subject: TLS-negotiation [1/n]: deprecate unused SaslAuth fields ......................................................................
TLS-negotiation [1/n]: deprecate unused SaslAuth fields This commit deprecates two fields in the SaslMessagePB.SaslAuth type: method: this field has been unused since 0.6. In 0.6 it was a required field, so this change technically breaks compat with 0.6 clients or servers, but I don't think we have or guarantee compat with pre 1.0. challenge: this field existed to allow the server to piggy back a challenge token along with the NEGOTIATE response, but we never used it. The Java client currently doesn't handle it, so we could not start using it in the future in a backwards compatible way, thus it's best to simplify things by removing it. Change-Id: I5e40e6453892a78b293f3dd63980eab839b671c1 Reviewed-on: http://gerrit.cloudera.org:8080/5755 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> --- M src/kudu/rpc/rpc_header.proto M src/kudu/rpc/sasl_client.cc M src/kudu/rpc/sasl_server.cc 3 files changed, 4 insertions(+), 20 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e40e6453892a78b293f3dd63980eab839b671c1 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
