Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [3/n]: rename negotiation protobuf messages ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5757/2/src/kudu/rpc/sasl_server.cc File src/kudu/rpc/sasl_server.cc: Line 176: TRACE("Waiting for next Negotiation message..."); > next negotiation message? Done PS2, Line 200: gotiation req > same Done PS2, Line 253: > maybe this should be renamed? Done http://gerrit.cloudera.org:8080/#/c/5757/2/src/kudu/rpc/sasl_server.h File src/kudu/rpc/sasl_server.h: Line 122: > nit: this should say 'negotiation message' or something Done -- To view, visit http://gerrit.cloudera.org:8080/5757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie24eec6e632c6e5064afa631eccb3877425fe354 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
