Dan Burkert has posted comments on this change.

Change subject: [java client] KUDU-1643 Prune hash partitions based on IN-list 
predicates
......................................................................


Patch Set 2:

(2 comments)

Just a couple of nits, otherwise looks good!  Thanks Haijie.

http://gerrit.cloudera.org:8080/#/c/5677/2/java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java
File java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java:

PS2, Line 488: List<Boolean>
Could this be a java.lang.BitSet?  Might be more efficient.


PS2, Line 489:    
indentation


-- 
To view, visit http://gerrit.cloudera.org:8080/5677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a793c23ff00d19b3d3d062bb222d2c725a93724
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Haijie Hong <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to