Matthew Jacobs has posted comments on this change. Change subject: WIP: KUDU-1713: add a client Partitioner API ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5775/1/src/kudu/client/client.h File src/kudu/client/client.h: PS1, Line 2191: not necessarily? http://gerrit.cloudera.org:8080/#/c/5775/2/src/kudu/client/client.h File src/kudu/client/client.h: Line 2216: Status PartitionRow(const KuduPartialRow& row, int* partition); > I guess my point isn't that the view you get is necessarily a consistent sn I agree it's a nice property to have, but FWIW for now in Impala we'll end up creating these on all hosts in a query so we won't be able to have a consistent view even within a query. I don't think we can change that until the metadata is something small and that we can serialize. -- To view, visit http://gerrit.cloudera.org:8080/5775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic08a078c75f15ef4200219b5260cfb99d79b72cc Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
