Adar Dembo has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed ......................................................................
Patch Set 1: (2 comments) Just passing through... http://gerrit.cloudera.org:8080/#/c/5820/1/src/kudu/security/init.cc File src/kudu/security/init.cc: Line 38: DEFINE_int32(kerberos_reinit_interval, 60, "Duration in minutes before which an attempt to " I don't have much context on the security work going on in Kudu, but I was wondering: would it be possible to use the expiration of the Kerberos credentials to dictate how long to sleep? That is, if we know our tickets are expiring in 6 hours, we can sleep until then, rather than waking up periodically? Ideally we wouldn't even need a thread, but schedule the future work as a task. Unfortunately, that facility is provided by the messenger in krpc, so using it might create a circular dependency. Line 86: SleepFor(MonoDelta::FromSeconds(FLAGS_kerberos_reinit_interval * 60)); Shouldn't this thread participate in the rest of the server lifecycle though? That is, if the server is shutdown, shouldn't we explicitly stop this thread? -- To view, visit http://gerrit.cloudera.org:8080/5820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4c072c1210216369e60eac88be4a20d9b166b2d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
