Mike Percy has posted comments on this change. Change subject: Make delete_table-test less flaky ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5830/2/src/kudu/integration-tests/delete_table-test.cc File src/kudu/integration-tests/delete_table-test.cc: Line 1013: AssertEventually([&]() { > Surprised this is needed given the WaitForNumTabletsOnTS() above. Can you e That function only waits for a certain number of tablets to be registered. There may be a period of time where the tablet is still in the process of being created in TSTabletManager::OpenTablet() and during that time the tablet is still in the transition_in_progress_ set. In most tests, we don't have to worry about it much because the client will retry writes, etc. -- To view, visit http://gerrit.cloudera.org:8080/5830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idaa6bc8fb760351e9ecd8c39ef93c59559ce62f8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
