Will Berkeley has posted comments on this change. Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/5439/7/src/kudu/client/client.cc File src/kudu/client/client.cc: PS7, Line 720: const Schema > Here and below should be 'const Schema&', otherwise it's making an implicit Done http://gerrit.cloudera.org:8080/#/c/5439/7/src/kudu/client/table-internal.h File src/kudu/client/table-internal.h: PS7, Line 42: const Schema& schema, : const PredicateMakerFunc& f) > These two should be lined up with the one above, so the 'const's are in a r Done -- To view, visit http://gerrit.cloudera.org:8080/5439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide23ab6d3cad524553aa6ea5c44570fdadde5ace Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes