Adar Dembo has posted comments on this change.

Change subject: Bump Squeasel version
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5855/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

Line 481:   ${CC:-gcc} $EXTRA_CFLAGS -std=c99 -O3 -DNDEBUG -fPIC -lcrypto -lssl 
-c "$SQUEASEL_SOURCE/squeasel.c"
> I think it works without because you're just generating a static library, a
Ah yes, that makes sense. We should drop -lcrypto and -lssl then.


-- 
To view, visit http://gerrit.cloudera.org:8080/5855
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5c69b412ff8f9e4c5eb1f35f86ee62e0348bf0c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to