Sailesh Mukil has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed ......................................................................
Patch Set 4: So the ASAN build fails because the renew thread is leaking all its allocations, since the thread runs forever and most of the objects are never freed. I tried adding a security::Shutdown() which gets called from ServerBase::Shutdown(), but that seems to not be of any use in the case of the tests since an ExternalDaemon is killed and not shutdown properly. So CheckForLeaks() would still complain and fail the test. The only option I see is to have a ScopedLeakCheckDisabler in the scope of the renew thread. However, that too makes me nervous since a lot of the structures can have nested allocations and future changes could introduce bugs easily. What do you think is the right path of action here? -- To view, visit http://gerrit.cloudera.org:8080/5820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4c072c1210216369e60eac88be4a20d9b166b2d Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
