Dan Burkert has posted comments on this change. Change subject: [security] add channel binding to krpc ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/5884/3/src/kudu/security/cert.cc File src/kudu/security/cert.cc: PS3, Line 69: NotAuthorized( > nit: would NotFound or NotSupported be a better fit? Done PS3, Line 104: CHECK > style nit: consider using OPENSSL_CHECK_OK instead Done http://gerrit.cloudera.org:8080/#/c/5884/3/src/kudu/security/openssl_util.h File src/kudu/security/openssl_util.h: PS3, Line 27: #include "kudu/gutil/strings/substitute.h" > nit: probably, this is no longer needed in this file. Done -- To view, visit http://gerrit.cloudera.org:8080/5884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id73fceebfcb47c881c30f6904cfd6fc6d80f50b8 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
