Dan Burkert has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds ......................................................................
Patch Set 1: OK I was misremembering - ASAN has always worked on macOS (at least as far back as when I ported Kudu to macOS), but it has always had false positives. TSAN has never worked, and the compiler would error if you passed -fsanitize=thread. However, as of late last year apple announced TSAN support in XCode 8, so it seems they have been working on it. The clang version in thirdparty (3.9.1) no longer errors when passed -fsanitize=thread (at least on OS X 10.10), which is heartening. I'm going to try and get tsan working on Kudu. -- To view, visit http://gerrit.cloudera.org:8080/5894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c105274f26bb185cdaae6c046536011445f19a1 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
