Sailesh Mukil has posted comments on this change. Change subject: KUDU-1865 (part 1): reduce some cross-thread allocations ......................................................................
Patch Set 1: (2 comments) I found a couple of bugs, but there are still some memory leaks I haven't been able to figure out. This now passes DEBUG testing. I'll keep at it. http://gerrit.cloudera.org:8080/#/c/5905/1/src/kudu/rpc/connection.cc File src/kudu/rpc/connection.cc: Line 621: DCHECK(this->reactor_thread()->reactor()->closing()); This is a use-after-free if the Connection object is shutdown and cleared from the ReactorThread::server_conns_ list. Since this new way of passing function pointers doesn't increase the refcount of the 'Connection' object, the object can get freed before this abort_func() gets called. http://gerrit.cloudera.org:8080/#/c/5905/1/src/kudu/rpc/reactor.cc File src/kudu/rpc/reactor.cc: Line 596: }; This still needs a dummy 'abort_func()', else it results in a runtime error. -- To view, visit http://gerrit.cloudera.org:8080/5905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d4d5f14fb302196b1797c712b21cfce81f157c1 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
