Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5924
to review the following change.
Change subject: Fix TSAN segfault on Centos 6
......................................................................
Fix TSAN segfault on Centos 6
The OpenSSL version shipped with Centos 6 appears to segfault if a
nullptr is passed to OBJ_find_sigid_algs with TSAN. I haven't been able
to actually figure out why, I haven't been succesful in finding the
Centos 6 source for OpenSSL, and the version it's based on correctly
checks for null[1]. Attempting to set a breakpoint on the function
yielded no source, even with the debuginfo OpenSSL rpm installed.
[1]
https://github.com/openssl/openssl/blob/OpenSSL_1_0_1e/crypto/objects/obj_xref.c#L115
Change-Id: I5ea3ad372f98ff423425858c09cb0977f372b2e5
---
M src/kudu/security/cert.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/5924/1
--
To view, visit http://gerrit.cloudera.org:8080/5924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ea3ad372f98ff423425858c09cb0977f372b2e5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>