David Ribeiro Alves has posted comments on this change. Change subject: compaction: Flush tablet metadata before updating stores ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5920/1/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: PS1, Line 281: TODO(mpercy): Is there ever a case where this could cause dangling : // references in the in-memory portion? Do we need to make this more atomic? would it be possible to add a test for this? PS1, Line 285: UNDO fishy... no need to use 'type'? PS1, Line 324: LOG(INFO) << "Opening delta block for read: " << new_block_id.ToString(); without tablet info this isn't likely valuable at info level. -- To view, visit http://gerrit.cloudera.org:8080/5920 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I958f4744f1b95c6a63e8c9105bd1c7552e43e6b9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
