Adar Dembo has posted comments on this change. Change subject: Add Google Breakpad support to Kudu ......................................................................
Patch Set 34: (1 comment) http://gerrit.cloudera.org:8080/#/c/5620/34/src/kudu/util/minidump.h File src/kudu/util/minidump.h: Line 86: __attribute__((unused)) std::atomic<bool> user_signal_handler_thread_running_; Hmm, I thought this typically goes after the variable declaration, not before. Also, use ATTRIBUTE_UNUSED from gutil/port.h, I think that's preferable. -- To view, visit http://gerrit.cloudera.org:8080/5620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I495695cc38b75377f20b0497093a81ed5baa887f Gerrit-PatchSet: 34 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
