Dan Burkert has posted comments on this change. Change subject: [security] use Cert::CheckKeyMatch() for sanity checks ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5938/1/src/kudu/security/ca/cert_management-test.cc File src/kudu/security/ca/cert_management-test.cc: PS1, Line 240: certiciate 'certificate' here and below http://gerrit.cloudera.org:8080/#/c/5938/1/src/kudu/security/server_cert_manager.cc File src/kudu/security/server_cert_manager.cc: PS1, Line 96: strayed X509 certificate I think this error message could be clearer, I'm not sure I'd know what 'strayed' means just given an error log of this. -- To view, visit http://gerrit.cloudera.org:8080/5938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47d9134377ad51af153accb00ce3ac4cf864cda1 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
