Alexey Serbin has posted comments on this change.

Change subject: [client] retry operation in case of ServiceUnavailable
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5964/1/src/kudu/client/client-internal.cc
File src/kudu/client/client-internal.cc:

Line 225:       continue;
> should we use the path below in case there's been a master failover?
I think so, but I was not sure about sending requests again if that was 
ServiceUnavailable response.  I will dig more to understand if that makes sense.

Yes, I'll add the test.

The good news is that even in this half-baked condition the patch fixed all the 
tests which failed with my recent patch (not counting that deadlock on master 
shutdown).


-- 
To view, visit http://gerrit.cloudera.org:8080/5964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae169ce1efe3950dfcb769594a1944d05e2ad8e7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to