Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Limit the message size in Status ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/5956/1//COMMIT_MSG Commit Message: Line 16: With the limits in place, we can have a maximum of 100 * 256 = 25KB of messages > We should probably document both of these limits in some part of the Javado Yeah, but I'm not sure where. All the tracing stuff is private. So I guess we could do it in KuduClient but then that information could get stale rather quickly. http://gerrit.cloudera.org:8080/#/c/5956/1/java/kudu-client/src/main/java/org/apache/kudu/client/Status.java File java/kudu-client/src/main/java/org/apache/kudu/client/Status.java: Line 34: // Limit the message size we get from the servers as it can be quite large. > Would be nice if this were configurable, but that's going to be tough witho Indeed, I'm not sure how to approach this. Line 35: static final int MAX_MESSAGE_LENGTH = 256; > @VisibleForTesting? Done Line 40: //private final WireProtocol.AppStatusPB appStatusPB; > Remove? oops Line 48: this.message = msg.length() > MAX_MESSAGE_LENGTH ? msg.substring(0, MAX_MESSAGE_LENGTH) : msg; > If the message exceeded 256 chars, we should provide some indication that i Yeah I was looking at common's StringUtils.abbreviate but we don't depend on it right now. I guess it's not that hard to add ... -- To view, visit http://gerrit.cloudera.org:8080/5956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5868da9ee6b4befd1dc863570b8e251369213ffa Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
