Alexey Serbin has submitted this change and it was merged. Change subject: [client] retry operation in case of ServiceUnavailable ......................................................................
[client] retry operation in case of ServiceUnavailable KUDU-1871 Kudu C++ client does not retry on ServiceUnavailable errors Follow the common retry path scenario for Kudu C++ client in case of ServiceUnavailable error as well, for single- and multi-master scenarios. Besides, cleaned up invocation sites of SyncLeaderMasterRpc: moved handling of ResponsePB::has_error() and converting the PB error into Status into the code of the SyncLeaderMasterRpc method template. This commit re-enables ClientTest::TestRetriesOnServiceUnavailable test which passes with this fix. Change-Id: Iae169ce1efe3950dfcb769594a1944d05e2ad8e7 Reviewed-on: http://gerrit.cloudera.org:8080/5964 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/client/client-internal.cc M src/kudu/client/client-test.cc M src/kudu/integration-tests/create-table-stress-test.cc M src/kudu/master/catalog_manager.h 4 files changed, 68 insertions(+), 72 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5964 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae169ce1efe3950dfcb769594a1944d05e2ad8e7 Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
