Jean-Daniel Cryans has posted comments on this change. Change subject: java: redo locking and simplify TabletClient ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/6017/3//COMMIT_MSG Commit Message: Line 21: down to trace caused several tests to fail due to exposing the above Happy to learn you figured this out so quickly. http://gerrit.cloudera.org:8080/#/c/6017/3/java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java: Line 106: nit: remove Line 108: private ReentrantLock lock = new ReentrantLock(); This can be final Line 288: * Quick and dirty way to close a connection to a tablet server, if it wasn't already closed. Update this javadoc, previously we weren't using disconnect in this class and it really was just for tests. BTW have you checked the tests that call this method and see if they need any changes? Previously this could be called even on disconnected TabletClients. -- To view, visit http://gerrit.cloudera.org:8080/6017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cc03572821dc3401a7c06108dd7376a3f3cff18 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
