Jean-Daniel Cryans has posted comments on this change. Change subject: java: set max status error length to 32KB ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6026/1/java/kudu-client/src/main/java/org/apache/kudu/client/Status.java File java/kudu-client/src/main/java/org/apache/kudu/client/Status.java: Line 37: static final int MAX_MESSAGE_LENGTH = 32*1024; > oh, I see. but the issue that we hit in terms of the thing that killed YARN I thought we printed KuduRpc.toString directly, but no you're right in their case it was that the Status contained the output of KuduRpc.toString. From AsyncKuduClient: Status statusTimedOut = Status.TimedOut(message + request); So now there's a double application of the max message length: for each RpcTraceFrame, and for the final RowError. So I guess your change is fine... But I'm realizing this might be confusing. Might be better yet to just limit getHumanReadableStringForTraces, although there's something nice about not keeping thousands of Status objects with potentially large messages. -- To view, visit http://gerrit.cloudera.org:8080/6026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4def8f3fe9debff1fbe72a90d5dc61c736baf42d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
