Adar Dembo has posted comments on this change. Change subject: KUDU-1881: Deserializing scan token should check nullability of column ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6040/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: Line 663: throw new AssertionError(); I think just calling Assert.fail() is more idiomatic. Below too. http://gerrit.cloudera.org:8080/#/c/6040/1/src/kudu/client/scan_token-internal.cc File src/kudu/client/scan_token-internal.cc: Line 95: return Status::IllegalState("unknown column in scan token", column.name()); Curious, what was your justification for converting these InvalidArgument errors into IllegalState? I can see an argument for either: the scan token is certainly an "argument" to this function, but it's also a piece of state that has been constructed well before this particular function call. http://gerrit.cloudera.org:8080/#/c/6040/1/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: Line 496: ASSERT_STR_MATCHES(s.ToString(), ".*unknown column 'a' in scan token"); How about before matching the string, you first ASSERT that you got a Status of a particular type (i.e. invalid argument, etc)? Line 506: ASSERT_STR_MATCHES(s.ToString(), I think your regexes are failing in the test. Probably below too. -- To view, visit http://gerrit.cloudera.org:8080/6040 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b4c835c948723eb9bc47131e894971b8e1a2c44 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
