Dan Burkert has posted comments on this change.

Change subject: [security] add --rpc_tls_ciphers flag
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6055/3/src/kudu/security/tls_context.cc
File src/kudu/security/tls_context.cc:

PS3, Line 50: ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305
> isn't CHACHA slower than AES given AESNI acceleration? https://calomel.org/
Perhaps.  In practice I don't think this cipher will ever by negotiated, since 
it would require OpenSSL >= 1.1.0, which is supported by approximately 0 
distros.  I think there is value in sticking to exactly the cipher suites that 
Mozilla recommends, since doing anything else can raise questions.


-- 
To view, visit http://gerrit.cloudera.org:8080/6055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I050e2295041a98fe2c3118c6258b910423bd3816
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to