Adar Dembo has posted comments on this change. Change subject: [security] security-flags ......................................................................
Patch Set 2: (2 comments) Just commenting on the overall approach; didn't look at the implementation. http://gerrit.cloudera.org:8080/#/c/6052/2//COMMIT_MSG Commit Message: PS2, Line 43: 2) It's really long, and the length doesn't add : useful description or specificity. 3) The short form (cert instead : of certificate) is common in database CLI configs [1], [2], [3]. I mentioned this last night in #kudu-security on Slack, but I'll repeat it here too; I'm curious whether anyone else feels the way I do. While I appreciate that consistency w.r.t. other databases is a useful thing, I'm concerned that the gain is outweighed by the loss of information in shortening some of these flag names. I for one appreciate the "_file" suffix in the webserver-related flags, which made it very clear that the flag value should be a path to a file. Likewise, "_key_" is more ambiguous than "_private_key_"; it's not immediately clear whether a private or public key is being requested. PS2, Line 54: --rpc_key is replacing --rpc_ssl_private_key. Copy/pasta. -- To view, visit http://gerrit.cloudera.org:8080/6052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa53348b8969e83d9f794e1e0553bdec12252d9a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
