Dan Burkert has posted comments on this change. Change subject: [security] add --rpc_tls_ciphers flag ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6055/7/src/kudu/security/tls_context.cc File src/kudu/security/tls_context.cc: PS7, Line 119: // compatibility" section of the Mozilla Server Side TLS recommendations, > Why not to add corresponding trait I looked into doing this, but I couldn't define the type traits inside of this ifdef, and this is the only place we currently use EC_KEY (and I don't expect we'll support any others in the nearterm). I opted to just use the explicit form instead of introducing the type traits in an additional ifdef. PS7, Line 125: : #elif OPENSSL_VERSION_NU > I wouldn't say 'unlike' here -- most of those API calls return 0 or somethi Done PS7, Line 127: > Consider using OPENSSL_RET_NOT_OK instead: woops, you are absolutely right. -- To view, visit http://gerrit.cloudera.org:8080/6055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I050e2295041a98fe2c3118c6258b910423bd3816 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
