Alexey Serbin has posted comments on this change. Change subject: [security] leader master sends public TSKs to tservers ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6065/1/src/kudu/integration-tests/master_cert_authority-itest.cc File src/kudu/integration-tests/master_cert_authority-itest.cc: Line 174: void SendTskRequestHBs(const shared_ptr<rpc::Messenger>& messenger, > instead of all this, maybe just add a new assertion to registration-test.cc Yep, that would be much better. Thanks! http://gerrit.cloudera.org:8080/#/c/6065/1/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: Line 170: auto tspks = server_->token_signer()->verifier().ExportKeys( > nit: maybe tsk_pks? seems you have a typo in this var name because it's too Good idea. Yep, I had typos in this :) Line 173: // TODO(aserbin): would Swap() work as well? > yea, I think if you use a non-const auto& in the for loop, you could Swap. let me try. -- To view, visit http://gerrit.cloudera.org:8080/6065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd65bda944be9d365580e2d4b37b293b4dcff3e0 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
