Dan Burkert has posted comments on this change. Change subject: java: support token authentication in negotiation ......................................................................
Patch Set 3: (6 comments) The truststore stuff is nasty, but I guess that's not surprising. All nits, code LGTM. http://gerrit.cloudera.org:8080/#/c/6047/3/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java: PS3, Line 121: SSLContext should this be updated? Line 280: // TODO: is this always true? It's not true of legacy servers. Line 358: // TODO(todd): should we also check whether we have a CA cert? Yes this is true, is it an issue in the C++ side as well? http://gerrit.cloudera.org:8080/#/c/6047/3/java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java File java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java: Line 43: */ Add stability annotations. Line 44: class SecurityContext { Should the Subject be added to this? Seems like they are appearing in pairs. http://gerrit.cloudera.org:8080/#/c/6047/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java: Line 105: whitespace -- To view, visit http://gerrit.cloudera.org:8080/6047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7da5809495d67b308828e83c857249b852f21db3 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
