Dan Burkert has posted comments on this change. Change subject: java: add a fake DNS resolver to avoid reverse DNS hangs ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6076/3/java/kudu-client/src/test/java/org/apache/kudu/client/FakeDNS.java File java/kudu-client/src/test/java/org/apache/kudu/client/FakeDNS.java: Line 48: private boolean installed = false; Seems to me this either shouldn't exist (because the caller should keep track of whether it's been installed), or it should be atomic (because the caller can't keep track of whether it's been installed by another thread). -- To view, visit http://gerrit.cloudera.org:8080/6076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife71d7a815c7ef2028e569476fba060481b00f97 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
