Mike Percy has posted comments on this change. Change subject: Use HumanReadableElapsedTime for MonoDelta::ToString() ......................................................................
Patch Set 4: > I have mixed feelings about this. I agree it's easier for a human > to read the output after this change, but it's also harder to do > things like grep/sort/etc on log files which include values with > different units. > > Where are we outputting monodeltas that you found this to be more > useful? Maybe we should have a new variant ToHumanReadableString() > or something? I was mostly using this during development while debugging. I can see your argument and since I don't have a burning need for this I'll come back to it later. -- To view, visit http://gerrit.cloudera.org:8080/6082 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I787071d6ac62b1dc9154ec7b1f9a5d4a3ce64af1 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
