Alexey Serbin has posted comments on this change. Change subject: negotiation: add tracing of negotiated authn type ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6079/1/src/kudu/rpc/negotiation.cc File src/kudu/rpc/negotiation.cc: Line 24: if replacing <ostream> with <iosfwd> in the headers, consider adding #include <ostream> PS1, Line 70: string nit: consider returning 'const char*' instead http://gerrit.cloudera.org:8080/#/c/6079/1/src/kudu/rpc/negotiation.h File src/kudu/rpc/negotiation.h: PS1, Line 20: #include <ostream> consider using instead: #include <iosfwd> -- To view, visit http://gerrit.cloudera.org:8080/6079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida0137503a9f43de0398b7a885e14aaef20cb567 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
