Dan Burkert has posted comments on this change. Change subject: IPKI: remove unused fields from cert code ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6115/1/src/kudu/master/master_cert_authority.cc File src/kudu/master/master_cert_authority.cc: Line 74: CaCertRequestGenerator::Config config = { "kudu-ipki/" + server_uuid_ }; This cert isn't scoped to the master, but instead the cluster. So perhaps the CN should be 'kudu-ipki-ca' or similar, given that we don't currently have cluster identifiers. http://gerrit.cloudera.org:8080/#/c/6115/1/src/kudu/security/ca/cert_management.h File src/kudu/security/ca/cert_management.h: Line 58: std::string cn; // subject field: CN Are you thinking we'll add back more fields later on? -- To view, visit http://gerrit.cloudera.org:8080/6115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3e6ff00fa33fe0156a04ead6f72db3432775cdb Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
