Alexey Serbin has posted comments on this change. Change subject: master: don't issue new authn tokens to TOKEN-authenticated users ......................................................................
Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6119/2/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: PS2, Line 387: rpc::RemoteUser::AUTHN_TOKEN > We are actually currently using tokens for unauthenticated access too, whic ok, may be it's worth adding a DCHECK() to enforce that condition. But it can be safely done later. -- To view, visit http://gerrit.cloudera.org:8080/6119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cb1daf75680bb78e6e5b3331ee346a9faa41ac0 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
