Adar Dembo has posted comments on this change. Change subject: Validate security flags with gflags validators ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6128/2/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: Line 115: extern Status ParseTriState(const char* flag_name, const string& flag_value, T* tri_state) { Why are all these functions marked 'extern'? Line 132: Status s = ParseTriState("--rpc_authentication", FLAGS_rpc_authentication, &authentication); To prevent the flag name and flag value becoming desynchronized, how about using google::GetCommandLineFlagInfoOrDie() to fetch the latter using the former? Line 249: if (!FLAGS_rpc_certificate_file.empty()) { Can you either CHECK that the rest are set, or add a comment saying that they've been checked? -- To view, visit http://gerrit.cloudera.org:8080/6128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bf2f7f54a1366b73157bf2426a16b0a197c9f50 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
