Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6029
to look at the new patch set (#4).
Change subject: KUDU-1880 Prevent eager ignoring of NULLs
......................................................................
KUDU-1880 Prevent eager ignoring of NULLs
Blocks use CopyNextAndEval() to set the decoder evaluation support
and to materialize its underlying data.
During a nullable block scan, if a NULL set of cells is reached before
the decoder evaluation is disabled (e.g. if the first rows in the
block are NULL), the rows will be prematurely marked as not in the
results set. If evaluating an IsNull predicate, this will yield
erroneous results.
This patch adds an API to set the decoder evaluation support without
calling CopyNextAndEval(). SetDecoderEvalSupport() must be called
before the scan occurs.
Additional tablet unit tests are also added to cover the IsNull
case with NULL values at the beginning of columns.
Change-Id: Ib418a4fcc2794ce2f686e864f51834fb4fb8b048
---
M src/kudu/cfile/binary_dict_block.h
M src/kudu/cfile/binary_plain_block.h
M src/kudu/cfile/block_encodings.h
M src/kudu/cfile/cfile_reader.cc
M src/kudu/tablet/CMakeLists.txt
A src/kudu/tablet/tablet-scan-correctness-test.cc
6 files changed, 432 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/6029/4
--
To view, visit http://gerrit.cloudera.org:8080/6029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib418a4fcc2794ce2f686e864f51834fb4fb8b048
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
