Alexey Serbin has posted comments on this change.

Change subject: [system_catalog] an option to reset CA entries in system table
......................................................................


Patch Set 1:

> > This is a little funny as a flag, since if you're running
 > > multi-master, and you start with this, you'll end up with a new
 > CA,
 > > and then on first fail-over, the second master will also create a
 > > new CA.
 > 
 > I'm also not a fan of one-shot flags. In my opinion we should
 > eliminate existing ones and avoid introducing new ones, so I'd also
 > be in favor of fashioning this into a CLI tool instead.

I agree -- it's better to have this functionality somewhere else.  Otherwise 
it's just a piece of code which is going to be used 1e-100 of all runtime, and 
that does not make much sense.

-- 
To view, visit http://gerrit.cloudera.org:8080/6135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c9cdab5f6a2887304f60705d2945d1462c369bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: No

Reply via email to