Alexey Serbin has posted comments on this change. Change subject: [security] protect against master SASL negotiation short-circuit ......................................................................
Patch Set 1: (2 comments) Looks good to me, just some nits. Does it make sense to add a test for this? http://gerrit.cloudera.org:8080/#/c/6148/1/src/kudu/rpc/client_negotiation.cc File src/kudu/rpc/client_negotiation.cc: PS1, Line 543: nit: consider adding const here const Status s = ... PS1, Line 594: nit: consider adding const here -- To view, visit http://gerrit.cloudera.org:8080/6148 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f3b3d4f47e887b48c1c704c900e9260c22cec3a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
