Adar Dembo has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/6134/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 812: LOG(INFO) << "No active consensus, ignoring callback"; Let's change this to WARNING. Line 991: return RaftPeerPB::UNKNOWN_ROLE; When is this method invoked? Will returning UNKNOWN_ROLE be OK? Line 1025: // on the system table, if any. Let's be more explicit and explain how it's important to do this before waiting on the outstanding task, because the transactions issued by the task may block forever if too many peers are down, causing a deadlock. Line 1034: // Wait for any outstanding table visitors to finish. Can you reword this comment so it's talking about the ElectedLeaderCb task? "Table visitor" isn't really the right terminology anymore since the task does so much more. -- To view, visit http://gerrit.cloudera.org:8080/6134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10ad66fe33d4696adf2a02a09e2790afa8869583 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
