Mike Percy has posted comments on this change. Change subject: WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6066/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 1561: // if (!state_->CheckNoConfigChangePendingUnlocked().ok()) { I don't think we need to explicitly truncate the log or something like that. Perhaps we can simply add a boolean flag to RaftConfigPB to indicate that the pending config checks in ReplicaState::SetPendingConfigUnlocked() and ReplicaState::SetCommittedConfigUnlocked() as well as RaftConsensus::AddPendingOperationUnlocked() can be ignored (only in the case when the pending config change is forced). So, when we force adoption of a new config by a node, the RaftConsensus subsystem doesn't reject it, even if there is already one pending. -- To view, visit http://gerrit.cloudera.org:8080/6066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I908d8c981df74d56dbd034e72001d379fb314700 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
