Alexey Serbin has posted comments on this change. Change subject: [security] use shorter RSA keys in tests ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6194/1/src/kudu/integration-tests/external_mini_cluster.cc File src/kudu/integration-tests/external_mini_cluster.cc: Line 1021: // Generate smaller RSA keys for tests. We are using strong/high TLS v1.2 > oh, duh... sorry np, I actually found it's not possible to add it for tablet servers since they don't know about that flag. It seems the way how we start/restart daemons for external mini-cluster needs some minor refactoring -- I'll do that as well as a part of this commit. Line 1026: flags.push_back("--tsk_num_rsa_bits=512"); > Also need to add an equivalent in the Java ExternalMiniCluster Done http://gerrit.cloudera.org:8080/#/c/6194/1/src/kudu/security/token_signer.cc File src/kudu/security/token_signer.cc: Line 39: DEFINE_int32(tsk_num_rsa_bits, 2048, > Could you also mark this flag experimental while you are here? Done -- To view, visit http://gerrit.cloudera.org:8080/6194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I180908763a1c520d8a6d8bbaaf981add9396db99 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
