David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns ......................................................................
Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/6129/8//COMMIT_MSG Commit Message: PS8, Line 20: This patch addresses this by forcing predicate evaluation by the : DefaultColumnValueIterator. nit: can you mention what particular test would fail without the fix? http://gerrit.cloudera.org:8080/#/c/6129/2/src/kudu/common/column_predicate.cc File src/kudu/common/column_predicate.cc: PS2, Line 599: colum > Is there a particular reason to favor using type_info()->name() vs just the the datatype is just a number, having the name helps with debugging. http://gerrit.cloudera.org:8080/#/c/6129/8/src/kudu/common/column_predicate.cc File src/kudu/common/column_predicate.cc: PS8, Line 599: column_.type_info()->name(); i meant that you should use GetTypeInfo(type)->name(), i.e. that you can get the type info in runtime. sorry if that wasn't clear -- To view, visit http://gerrit.cloudera.org:8080/6129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic10919962d11effbb1b66d97660acd012b6b4be9 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Ram Mettu <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
