Adar Dembo has posted comments on this change. Change subject: KUDU-1834 Don't redact KuduRowResult::ToString() ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6222/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS1, Line 1087: bool old_tls_redact_user_data = tls_redact_user_data; : bool old_should_redact_log = g_should_redact_log; : bool old_g_should_redact_flag = g_should_redact_flag; : tls_redact_user_data = true; : g_should_redact_log = true; : g_should_redact_flag = true; Would be simpler to redact via google::SetCommandLineOption(); it'll cause the validators to be called again. Plus you don't need to store/restore the old values; it'll be taken care of via a FlagSaver I believe. Line 1093: ASSERT_NO_FATAL_FAILURE(InsertTestRows(client_table_.get(), Nit: use the shorter NO_FATALS() in new code. http://gerrit.cloudera.org:8080/#/c/6222/1/src/kudu/client/scan_batch.cc File src/kudu/client/scan_batch.cc: Line 288: ScopedDisableRedaction no_redaction; Add a short comment here justifying it. -- To view, visit http://gerrit.cloudera.org:8080/6222 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If966e9ba76f747de85350ffa2b91fcf05a9ad324 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
